Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating library from player #245

Merged
merged 10 commits into from
Jul 28, 2020
Merged

Separating library from player #245

merged 10 commits into from
Jul 28, 2020

Conversation

devgianlu
Copy link
Member

@devgianlu devgianlu commented Jul 22, 2020 •
edited
Loading

  • Move stuff to lib module
  • Rename core module to player
  • Remove common module
  • Create proper READMEs for the two new modules
  • Refactor api module
  • General refactoring/cleaning up

@devgianlu devgianlu added the enhancement New feature or request label Jul 22, 2020
@devgianlu devgianlu linked an issue Jul 22, 2020 that may be closed by this pull request
Separate out audio functionality #234
Closed
@devgianlu devgianlu mentioned this pull request Jul 22, 2020
Closed
@devgianlu devgianlu marked this pull request as draft July 23, 2020 13:36
@devgianlu
Copy link
Member Author

@dsvensson I've finally separated librespot-java into two modules: lib and player. Let me know what you think.

@devgianlu devgianlu marked this pull request as ready for review July 27, 2020 21:04
@devgianlu devgianlu merged commit 17ba408 into dev Jul 28, 2020
@devgianlu devgianlu deleted the lib-module branch July 28, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate out audio functionality
1 participant
@devgianlu